Skip to content

🔖 Release 3.4.1#225

Merged
stevenbal merged 2 commits intomasterfrom
release/3.4.1
Feb 5, 2026
Merged

🔖 Release 3.4.1#225
stevenbal merged 2 commits intomasterfrom
release/3.4.1

Conversation

@TimdeBeer1
Copy link
Contributor

@TimdeBeer1 TimdeBeer1 commented Jan 26, 2026 •
edited
Loading

Fixes maykinmedia/objects-api#721

Changes

Release

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.69%. Comparing base (47079a2) to head (b9524bb).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   86.69%   86.69%           
=======================================
  Files          79       79           
  Lines        1135     1135           
  Branches       74       74           
=======================================
  Hits          984      984           
  Misses        135      135           
  Partials       16       16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TimdeBeer1 TimdeBeer1 marked this pull request as ready for review January 26, 2026 14:23
@TimdeBeer1 TimdeBeer1 force-pushed the release/3.4.1 branch 2 times, most recently from 442a585 to 0f0954e Compare January 27, 2026 08:20
stevenbal
stevenbal requested changes Jan 27, 2026
View reviewed changes
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimdeBeer1 could you redo the commits to make sure the library upgrades are in their own commit before the release commit? Currently it seems the last commit is about upgrading dependencies but also contains changes to the changelog

@TimdeBeer1 TimdeBeer1 force-pushed the release/3.4.1 branch 5 times, most recently from 1da432c to 3d7efd7 Compare January 27, 2026 09:26
@TimdeBeer1 TimdeBeer1 requested a review from stevenbal January 27, 2026 09:30
stevenbal
stevenbal requested changes Jan 27, 2026
View reviewed changes
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimdeBeer1 could you rebase on master and make sure #226 is mentioned in the changelog as well?

@stevenbal
Copy link
Collaborator

stevenbal commented Jan 27, 2026

We'll also need https://github.com/maykinmedia/objecttypes-api/pull/227/files for this, because removing the migration for linkable_to_zaken could cause issues for installations that deployed 3.4.0 at some point

@TimdeBeer1 TimdeBeer1 force-pushed the release/3.4.1 branch 2 times, most recently from 609824d to 9d3cbb1 Compare January 27, 2026 14:15
@TimdeBeer1 TimdeBeer1 requested a review from stevenbal January 27, 2026 14:20
stevenbal
stevenbal requested changes Feb 3, 2026
View reviewed changes
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you upgrade django to 5.2.11?

@Floris272 Floris272 self-assigned this Feb 3, 2026
@Floris272 Floris272 force-pushed the release/3.4.1 branch 4 times, most recently from f10d52e to e43344c Compare February 3, 2026 15:01
@Floris272 Floris272 requested a review from stevenbal February 3, 2026 15:44
@stevenbal stevenbal assigned stevenbal and unassigned Floris272 Feb 5, 2026
@stevenbal stevenbal merged commit 39db53e into master Feb 5, 2026
24 checks passed
@stevenbal stevenbal deleted the release/3.4.1 branch February 5, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenbal stevenbal stevenbal approved these changes

@danielmursa-dev danielmursa-dev danielmursa-dev approved these changes

Assignees

@stevenbal stevenbal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prepare Objecttypes release 3.4.1

5 participants

@TimdeBeer1 @codecov-commenter @stevenbal @danielmursa-dev @Floris272